Phabricatorを使用したcode review

1990 ワード

ローカル開発プロセス:

#        develop
git checkout -b develop

#       ,    
git add .
git commit -m "message"

#       
arc lint

#    code review
arc diff
#    code review   ,       ,  Title、Summary、Test Plan、Reviewers

#       ,           code review(   revision       code review    id,   D1234)
arc diff --update 1234
# --update 1234      ,         review  

# reviewer    Accept   ,    
arc land develop
#            revision,   revision  (   1234):
arc land --revision 1234
# land   ,feature branch       
# land           merge    squash merge   master   ,         ,    master         

arc diff
arc diff origin/develop

arc help land, land target :


A target branch is selected by examining these sources in order:

  - the --onto flag;
  - the upstream of the current branch, recursively (Git only);
  - the arc.land.onto.default configuration setting;
  - or by falling back to a standard default:
    - "master" in Git;
    - "default" in Mercurial.

arc land #    target master,       master
arc land --onto foo/bar #        foo/bar
arc land develop
arc land develop --onto foo/bar

arc set-config arc.land.onto.default foo/bar

~/.arcrc :


cat ~/.arcrc
{
  "hosts": {
    "https://phabricator.xxx.ai/api/": {
      "token": "xxx"
    }
  },
  "config": {
    "arc.land.onto.default": "foo/bar"
  }
}

Phabricator code review

Phabricator User Documentation